Fix issue with useQuery returning loading: true state during server-side rendering with skip: true
#9679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanmarks: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
benjamn
force-pushed
the
nathanmarks/ssr-query-loading-bug
branch
from
413dff4
to
ffa7a2e
Compare
benjamn
approved these changes
May 5, 2022
There was a problem hiding this comment.
Thanks for diagnosing and testing and fixing this issue @nathanmarks!
benjamn
changed the title
useQuery returning loading: true state during server-side rendering with skip: true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with useQuery returning loading state in SSR with skip
Fixes #9096