Prevent useLazyQuery from making duplicate requests when execution function first called
#9684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a side effect of not throwing any ApolloError objects (see removed code), this commit also fixes issue #9669.
This was
linked to
issues
May 5, 2022
benjamn
requested review from
brainkim and
hwillson
and removed request for
brainkim
This perhaps gives some reassurance the goals of issue #9142 are still achievable, in the sense that network errors can be obtained from the Promise returned by the useLazyQuery execution function, even if those errors are not thrown (and the Promise is never rejected).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the following issues:
As justification for #9669, none of our error policies say anything about throwing errors; they just control whether/when the
result.dataand/orresult.errorproperties will be defined. Throwing an error is similar to the default policy,none, but needlessly discards result properties other thanresult.error. If you want a rejectedPromise, attach athencallback and throwresult.errorwhen it's defined.I'm giving this justification because I am aware it stands in conflict with an issue we recently "fixed" (perhaps a bit too hastily): #9142 (comment)