Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee Concast cleanup without Observable cancelled prematurely rejection #9701

Merged
merged 4 commits into from
May 9, 2022
Merged

Guarantee Concast cleanup without Observable cancelled prematurely rejection #9701

merged 4 commits into from
May 9, 2022

Commits on May 9, 2022

  1. Guarantee Concast cleanup without 'Observable cancelled prematurely' … 

    …rejection.
    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    142694e View commit details
    Browse the repository at this point in the history

  2. Add minimal unit tests for Concast class. 

    The Concast class is heavily exercised by much of our test suite, so I
would not say it is currently untested, but I would love to expand on
these Concast-specific unit tests in the future.
    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7da807e View commit details
    Browse the repository at this point in the history

  3. Add basic regression test for issues #7608 and #9690.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    39e491e View commit details
    Browse the repository at this point in the history

  4. Mention PR #9701 in CHANGELOG.md.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ad31810 View commit details
    Browse the repository at this point in the history