Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utilities): missing incoming field handling in offsetLimitPagination #9705

Merged
merged 3 commits into from May 16, 2022

Conversation

shobhitsharma
Copy link
Contributor

@shobhitsharma shobhitsharma commented May 11, 2022

This handles an edge case reported #8708, where missing incoming argument is null or an empty value that throws TypeError when fetch call returns an error.

Stacktrace

image-2022-03-25-09-28-52-401

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@shobhitsharma: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@shobhitsharma shobhitsharma marked this pull request as draft May 11, 2022 12:03
@shobhitsharma shobhitsharma marked this pull request as ready for review May 12, 2022 07:40
@shobhitsharma
Copy link
Contributor Author

@benjamn Can you please have a look at this?

@jpvajda jpvajda added the 🏓 awaiting-team-response requires input from the apollo team label May 13, 2022
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me—thanks @shobhitsharma!

As a side note, please feel free to copy/paste these helper functions and tweak them locally to suit your needs.

@benjamn benjamn merged commit 02a78df into apollographql:main May 16, 2022
@benjamn benjamn added this to the v3.6.x patch releases milestone May 16, 2022
@benjamn benjamn added 💸 caching and removed 🏓 awaiting-team-response requires input from the apollo team labels May 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants