useSyncExternalStore refinements
#9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be safe because we do not export the useSyncExternalStore hook publicly.
benjamn
commented
May 11, 2022
Comment on lines
-18
to
-29
| export const useSyncExternalStore: RealUseSESHookType = ( | ||
| // When/if React.useSyncExternalStore is defined, delegate fully to it. | ||
| export const useSyncExternalStore: RealUseSESHookType = realHook || (( | ||
| subscribe, | ||
| getSnapshot, | ||
| getServerSnapshot, | ||
| ) => { | ||
| // When/if React.useSyncExternalStore is defined, delegate fully to it. | ||
| const realHook = (React as { | ||
| useSyncExternalStore?: RealUseSESHookType; | ||
| }).useSyncExternalStore; | ||
| if (realHook) { | ||
| return realHook(subscribe, getSnapshot, getServerSnapshot); | ||
| } |
There was a problem hiding this comment.
I think you'll appreciate this change @brainkim
|
Thank you for doing this! |
brainkim
approved these changes
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce @SimenB's webpack bug report from #9675 (comment), and I am confident this PR will fix that problem.
I also restructured the code so that when the real
React.useSyncExternalStoreis available, it will be the same (===) function we export asuseSyncExternalStore, without any additional wrapping.