Allow useLazyQuery(query, { defaultOptions }) to benefit from defaultOptions.variables
#9762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
May 24, 2022
benjamn
changed the title
useLazyQuery to benefit from options.defaultOptions.variablesuseLazyQuery(query, { defaultOptions }) to benefit from defaultOptions.variables and client.defaultOptions.watchQuery.variables
benjamn
changed the title
useLazyQuery(query, { defaultOptions }) to benefit from defaultOptions.variables and client.defaultOptions.watchQuery.variablesuseLazyQuery(query, { defaultOptions }) to benefit from defaultOptions.variables
This makes it easier to see that we pass equivalent/consistent variables both when initially calling client.watchQuery and when calling this.observable.reobserve.
benjamn
force-pushed
the
fix-useLazyQuery-defaultOptions-merging
branch
from
f80c7fd
to
3e59b3d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing PR #9758, I noticed that
useLazyQuerywas unable to see/use anydefaultOptions.variablespassed touseLazyQuery(query, { defaultOptions: { variables }})(a feature introduced by PR #9563), because thedefaultOptionsonly mattered when theObservableQuerywas first created withclient.watchQuery(see #9665), and not when theuseLazyQueryexecution function is later called. This PR fixes that oversight, allowinguseLazyQueryto benefit fromoptions.defaultOptions.variables, and also ensures globalclient.defaultOptions.watchQuery.variablesare merged at the same time.