Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the getting started guide to use the FlyBy API #9851

Merged
merged 10 commits into from
Jun 29, 2022

Conversation

rkoron007
Copy link
Contributor

The Apollo Client Getting started article currently relies on a Codesandbox instance that queries the Coinbase API. We decided that it'd be better to better to update this article to use an API that Apollo manages and updates (I ended up going with the FlyBy API from Voyage I).

@rkoron007 rkoron007 self-assigned this Jun 24, 2022
@rkoron007
Copy link
Contributor Author

@jpvajda Wasn't sure if you wanted to review this too— but wanted to let you know we were updating the "Getting Started" guide! (I also added a note about downgrading graphql for those running into this problem: #9659 )

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Finished a feedback pass

docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
rkoron007 and others added 3 commits June 24, 2022 14:05
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great from my perspective, thanks for improving this guide!

docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
rkoron007 and others added 2 commits June 28, 2022 13:12
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
@rkoron007
Copy link
Contributor Author

As per our conversation @StephenBarlow, I updated this tutorial to directly use the App.js file instead of putting everything in index.js. I also updated the CodeSandbox to match!

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo thanks for incorporating all these pesky changes! Just a last couple things and then merge whenever's good! 🎉

docs/source/get-started.mdx Outdated Show resolved Hide resolved
docs/source/get-started.mdx Outdated Show resolved Hide resolved
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
@rkoron007 rkoron007 merged commit 2974886 into main Jun 29, 2022
@rkoron007 rkoron007 deleted the RK/Switch-API-for-getting-started branch June 29, 2022 01:38
MrDoomBringer pushed a commit to MrDoomBringer/apollo-client that referenced this pull request Jul 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants