Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ignoring errors sections in link and error handling docs. #9854

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Remove Ignoring errors sections in link and error handling docs. #9854

merged 4 commits into from
Jun 28, 2022

Conversation

alessbell
Copy link
Member

@alessbell alessbell commented Jun 24, 2022 •
edited

This PR removes two identical sections on ignoring errors in both the Error Link and Error Handling docs as ignoring errors by setting response.errors = null; is no longer a recommended practice.

Closes #6758

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes) N/A
  • Make sure all of the significant new logic is covered by tests N/A

@alessbell alessbell requested a review from benjamn June 24, 2022 17:50
hwillson
hwillson approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @alessbell! 🎉

@alessbell alessbell merged commit 5ac993d into main Jun 28, 2022
MrDoomBringer pushed a commit to MrDoomBringer/apollo-client that referenced this pull request Jul 7, 2022
@alessbell @MrDoomBringer
Remove Ignoring errors sections in link and error handling docs. (apo…
a50d7c5 
…llographql#9854)
@alessbell alessbell deleted the issue-6758-onError-does-not-have-response branch July 13, 2022 23:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onError does not have "response"
2 participants
@alessbell @hwillson