Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onQueryUpdate missing parameters #9898

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

capucho
Copy link
Contributor

@capucho capucho commented Jul 11, 2022

onQueryUpdate callback requires the result and complete fields. However, those fields are not defined in the callback function in the documentation.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

onQueryUpdate callback requires the `result` and ` complete` fields. However, those fields are not defined in the callback function in the documentation.
@apollo-cla
Copy link

@capucho: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@capucho capucho changed the title docs(refetching): add onQueryUpdate missing params Add onQueryUpdate missing parameters Jul 11, 2022
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! We appreciate the PR.

@jpvajda jpvajda self-assigned this Jul 14, 2022
@jpvajda jpvajda merged commit 1ef6a10 into apollographql:main Jul 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants