Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type policy inheritance #9905

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Type policy inheritance #9905

merged 6 commits into from
Jul 19, 2022

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented Jul 15, 2022

This PR attempts to documented the TypePolicy Inheritance feature introduced in #7065

@jpvajda jpvajda mentioned this pull request Jul 15, 2022
Closed
18 tasks
@jpvajda
Copy link
Contributor Author

jpvajda commented Jul 15, 2022

👋 @alessbell @MrDoomBringer @hwillson @benjamn

Here's an attempt to document this feature! Could someone provide a quick review?

hwillson
hwillson reviewed Jul 16, 2022
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jpvajda! 🎉 I'm wondering if this section would be better suited in another part of the docs, like maybe in https://www.apollographql.com/docs/react/caching/cache-field-behavior or even https://www.apollographql.com/docs/react/caching/advanced-topics. Type policy inheritance is more of an intermediate to advanced topic so putting it on one of the first configuring the cache pages might me a little off-putting to newcomers.

docs/source/caching/cache-configuration.mdx Outdated Show resolved Hide resolved
@jpvajda
Copy link
Contributor Author

jpvajda commented Jul 18, 2022

@hwillson Thanks for the review! I was thinking advanced topics would be a good location for this as well, so let me move this section.

@jpvajda jpvajda requested a review from hwillson July 18, 2022 17:28
@jpvajda
Copy link
Contributor Author

jpvajda commented Jul 18, 2022

@hwillson all set for a fresh review. 🤜 🤛

hwillson
hwillson approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: * 💯

alessbell
alessbell approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, otherwise LGTM!

docs/source/caching/advanced-topics.mdx Outdated Show resolved Hide resolved
@jpvajda @alessbell
Update docs/source/caching/advanced-topics.mdx
1fef842 
Co-authored-by: alessia <github@bellisar.io>
@jpvajda jpvajda merged commit fa3c3c9 into main Jul 19, 2022
@jpvajda jpvajda deleted the typePolicy-inheritance branch July 19, 2022 21:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@alessbell alessbell alessbell approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@MrDoomBringer MrDoomBringer Awaiting requested review from MrDoomBringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpvajda @hwillson @alessbell