Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when failing to match mock variables #9921

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

zinkkrysty
Copy link
Contributor

"which" was ambiguous and could relate to the actual query that was made. Instead the variables are referring to the mock that was found, but the variables didn't match for it.

I spent quote some time confused and wondering, until I finally got what the message meant.

Checklist:

  • Make sure all of the significant new logic is covered by tests

"which" was ambiguous and could relate to the actual query that was made. Instead the variables are referring to the mock that was found, but the variables didn't match for it.
@apollo-cla
Copy link

@zinkkrysty: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@MrDoomBringer MrDoomBringer self-assigned this Sep 12, 2022
Copy link
Contributor

@MrDoomBringer MrDoomBringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clarification seems good here. I went ahead and updated the test snapshots to reflect this change. Welcome to the codebase!

All the best,
Emmanuel, Intern :-)

@MrDoomBringer MrDoomBringer merged commit b0e8c0c into apollographql:main Sep 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants