Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make react-dom an optional peer dependency #9933

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix: make react-dom an optional peer dependency #9933

merged 4 commits into from
Sep 8, 2022

Conversation

brillout
Copy link
Contributor

I guess this doesn't need explanation, but I can provide one if needs be.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@brillout: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

alessbell
alessbell reviewed Jul 24, 2022
View reviewed changes
Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @brillout, thanks for the PR! Should be able to merge this in tomorrow.

@jpvajda jpvajda linked an issue Jul 25, 2022 that may be closed by this pull request
Vite 3 Bug (ESM/CJS problem) #9938
Closed
@jpvajda jpvajda self-assigned this Sep 1, 2022
@jpvajda
Copy link
Contributor

jpvajda commented Sep 1, 2022

@alessbell any objections to merging this in now? cc @hwillson

@jpvajda jpvajda removed their assignment Sep 6, 2022
@alessbell
Copy link
Member

No objections! This LGTM, thanks @jpvajda

@jpvajda jpvajda merged commit caf900b into apollographql:main Sep 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alessbell alessbell alessbell left review comments

Assignees
No one assigned
Labels
🛫 in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite 3 Bug (ESM/CJS problem)
4 participants
@brillout @apollo-cla @jpvajda @alessbell