Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves the React hooks entrypoint from @apollo/client to @apollo/client/react #9940

Merged
merged 9 commits into from
Sep 15, 2022
Merged

Moves the React hooks entrypoint from @apollo/client to @apollo/client/react #9940

merged 9 commits into from
Sep 15, 2022

Conversation

MrDoomBringer
Copy link
Contributor

@MrDoomBringer MrDoomBringer commented Jul 25, 2022 •
edited
Loading

See this milestone for more information: #8190

This PR aims to remove the react entrypoint from @apollo/client and have it accessible only through @apollo/client/react.

  • Adjusts @apollo/client and @apollo/client/react accordingly
  • Adds an @apollo/testing/react entrypoint, used primarily for MockedProvider
  • Includes a basic codemod to help move react hook imports out of /client and into client/react
  • Includes a basic migration guide, currently only including information about this change
  • Updates all AC React docs

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@MrDoomBringer MrDoomBringer marked this pull request as draft July 25, 2022 19:20
@hwillson hwillson linked an issue Jul 26, 2022 that may be closed by this pull request
Feature: Removing React from the default @apollo/client entry point #8190
Closed
4 tasks
@MrDoomBringer MrDoomBringer linked an issue Jul 27, 2022 that may be closed by this pull request
setContext converts all headers to lower case #6741
Closed
@MrDoomBringer MrDoomBringer removed a link to an issue Jul 27, 2022
setContext converts all headers to lower case #6741
Closed
@hwillson
Copy link
Member

Super excited about this! Let us know when you think this is ready for review @MrDoomBringer - thanks!

@MrDoomBringer MrDoomBringer marked this pull request as ready for review July 29, 2022 07:28
@MrDoomBringer MrDoomBringer changed the title [Draft] Removing React from the default @apollo/client entrypoint Moves the React hooks entrypoint from @apollo/client to @apollo/client/react Jul 29, 2022
@hwillson hwillson self-requested a review August 12, 2022 15:49
@jpvajda
Copy link
Contributor

jpvajda commented Sep 1, 2022

@MrDoomBringer 👋 can this be merged in now?

@MrDoomBringer
Copy link
Contributor Author

@jpvajda Yup! Just waiting for an approval review now :-)

@benjamn benjamn merged commit 3c530f1 into apollographql:release-4.0 Sep 15, 2022
@benjamn benjamn added this to the Release 4.0 milestone Sep 15, 2022
@bignimbus bignimbus mentioned this pull request Sep 27, 2022
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alessbell alessbell alessbell left review comments

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

@hwillson hwillson Awaiting requested review from hwillson

Assignees

@MrDoomBringer MrDoomBringer

Labels
📦 bundle size 🎄 dependencies 🍳 breaking change ⚛️ React-related 🔬 testing-utilities 🛠 tooling
Projects
None yet
Milestone
Release 4.0
Development

Successfully merging this pull request may close these issues.

Feature: Removing React from the default @apollo/client entry point
5 participants
@MrDoomBringer @hwillson @jpvajda @alessbell @benjamn