Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick doc change to clarify subscriptions don't work in client schema #9944

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

MrDoomBringer
Copy link
Contributor

Adds explicit clarification that we don't support subscriptions polling the client state. See the long-open issue #5322 for more information.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @MrDoomBringer! I'm wondering if we can expand the note a bit - see below.

docs/source/data/subscriptions.mdx Outdated Show resolved Hide resolved
@MrDoomBringer MrDoomBringer force-pushed the client-subscription-clarification branch from 3f57046 to f2bf3bd Compare July 28, 2022 23:54
@MrDoomBringer MrDoomBringer linked an issue Jul 28, 2022 that may be closed by this pull request
MrDoomBringer and others added 2 commits July 29, 2022 03:34
Co-authored-by: Hugh Willson <hugh@octonary.com>
@MrDoomBringer MrDoomBringer force-pushed the client-subscription-clarification branch from f2bf3bd to 730eb49 Compare July 29, 2022 07:34
@MrDoomBringer MrDoomBringer merged commit 44692ad into main Jul 29, 2022
@MrDoomBringer MrDoomBringer self-assigned this Sep 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions do not work in client schema
3 participants