Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CONTRIBUTING.md #9953

Merged
merged 3 commits into from
Aug 2, 2022
Merged

chore: update CONTRIBUTING.md #9953

merged 3 commits into from
Aug 2, 2022

Conversation

alessbell
Copy link
Member

@alessbell alessbell commented Jul 29, 2022

Updates CONTRIBUTING.md.

Two minor changes:
1. since merging #9942 contributors should run npm i --legacy-peer-deps to install dependencies since we install two versions of React/ReactDOM/RTL as dev dependencies in order to run our tests against both which causes errors on npm i (cc: @benjamn @MrDoomBringer @hwillson @jpvajda) this was taken care of with an .npmrc file in #9967
2. updates table of contents to include some missing items

ToC before:
CleanShot 2022-07-29 at 14 04 08@2x

ToC after:
CleanShot 2022-07-29 at 14 08 05@2x

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alessbell alessbell merged commit 0a920db into main Aug 2, 2022
@alessbell alessbell deleted the update-contributing-guide branch August 2, 2022 01:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants