Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error handling example in docs #9996

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

MrDoomBringer
Copy link
Contributor

The wording of the documentation in the Advanced section of Handling Operation Errors implies that the example will have an onError link connected to an HttpLink, but the code seems to be instead a copy of the example from the directional composition section. This updates the code to match the description above it.

Old docs screenshot:

Closes #9995

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - thanks @MrDoomBringer!

@StephenBarlow
Copy link
Contributor

Ah yeah, whoopsie! Thanks 😄

@MrDoomBringer MrDoomBringer merged commit 18c8af4 into main Aug 16, 2022
@MrDoomBringer MrDoomBringer deleted the MrDoomBringer-patch-1 branch September 6, 2022 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - Link error handling wrong example
3 participants