update @requires test to verify the functionality #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
type: bug
|
Whats the approach to adding these changes to implementations? will that be done in this PR? How can library maintainers help? |
|
@kdawgwilk 👋 I'll split the PR into the schema + test update and will have separate implementations PR. Once the test PR is merged, you will be able to update the implementations without waiting for additional changes from my side. Thanks for the help! |
dariuszkuc
force-pushed
the
requires_tests
branch
3 times, most recently
from
261172d
to
6adf888
Compare
|
Does |
|
@ddebrunner yes, I'll update it once the #152 is merged |
dariuszkuc
force-pushed
the
requires_tests
branch
from
6adf888
to
6300201
Compare
Updating `users` and `products` subgraph schemas to allow for testing the support of `@requires` functionality in the implementing subgraph. This is a breaking change as we modify the schema so all the existing implementations will be impacted. Changes: * `users` subgraph ```graphql type User @key(fields:"email") { email:ID! name: String totalProductsCreated: Int yearsOfEmployment: Int! # <-- new field } ``` * `products` subgraph ```graphql extend type User @key(fields: "email") { averageProductsCreatedPerYear: Int @requires(fields: "yearsOfEmployment") # <-- test `@requires` functionality email: ID! @external name: String @OverRide(from: "users") totalProductsCreated: Int @external yearsOfEmployment: Int! @external # <-- field from the users subgraph used by @requires } ``` Related Issues: * apollographql#128
dariuszkuc
force-pushed
the
requires_tests
branch
from
6300201
to
7654316
Compare
hwillson
approved these changes
Aug 5, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
usersandproductssubgraph schemas to allow for testing the support of@requiresfunctionality in the implementing subgraph. This is a breaking change as we modify the schema so all the existing implementations will be impacted.Changes:
userssubgraphproductssubgraphImplementation updates will follow in separate PRs.
Related Issues: