update product subgraph test schema with additional @key test cases #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
product
subgraph with additional entites to separate testing for various@key
test cases. Previously we were testing single entity that was supposed to define multiple@key
directives. This was problematic as not all implementations support repeatable directives and we never checked whether given@key
test case was actually present in the schema (test was executing_entities
query only).Schema changes (existing fields and types are omitted for clarity):
Update
@key
tests cases to verify:@key
functionality againstUser
type@key
functionality againstDeprecatedProduct
type@key
functionality againstProductResearch
type@key
functionality againstProduct
type (this test combines old tests into a single one)Related Issues:
@key
directive use cases #149