Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gqlgen update for compatibility #227

Closed
wants to merge 2 commits into from

Conversation

StevenACoffman
Copy link
Contributor

Hello, This is a WIP to see if the recent 99designs/gqlgen#2371 would fix the subgraph compatibility problem reported by 99designs/gqlgen#2357

Not sure how to run the full suite, but this is an attempt to trigger it.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@apollo-cla
Copy link

@StevenACoffman: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@StevenACoffman
Copy link
Contributor Author

@lleadbet @dariuszkuc I am looking for help on how to see the test failures here that caused the recent regression in #223 regarding Federation V1 compatibility for gqlgen.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@dariuszkuc
Copy link
Member

dariuszkuc commented Sep 15, 2022

Hello 👋

For repro:

  1. uncomment @requires directive from schema.graphqls
  2. start gateway + subgraphs locally (see CONTRIBUTING.md for details)
  3. run following query against the gateway to observe the broken behavior
query {
  product(id: "apollo-federation") {
    createdBy {
      averageProductsCreatedPerYear
      email
    }
  }
}

OR run following against gqlgen server directly

query {
    _entities(representations: [{ "__typename": "User", "email": "support@apollographql.com" }]) {
        ...on User {
          averageProductsCreatedPerYear
          email
        }
      }
    }
}

@dariuszkuc
Copy link
Member

You can see the compatibility test results under checks -> https://github.com/apollographql/apollo-federation-subgraph-compatibility/actions/runs/3063889683 (NOTE: @requires is currently commented out from the schema)

@dariuszkuc
Copy link
Member

Closing this PR as it does not fix the underlying issue.

@dariuszkuc dariuszkuc closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants