Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation nuwave/lighthouse #68

Merged
merged 4 commits into from Feb 16, 2022
Merged

Add implementation nuwave/lighthouse #68

merged 4 commits into from Feb 16, 2022

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Feb 6, 2022

No description provided.

@hwillson hwillson self-assigned this Feb 6, 2022
@olivernybroe olivernybroe mentioned this pull request Feb 7, 2022
Closed
@hwillson
Revert to the original example data set
d2bf649 
We want to keep these as arrays for now.
hwillson
hwillson approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @spawnia!

@hwillson hwillson merged commit 4d95452 into apollographql:main Feb 16, 2022
@spawnia spawnia deleted the lighthouse branch February 17, 2022 07:55
@spawnia
Copy link
Contributor Author

spawnia commented Feb 17, 2022

Hi @hwillson, thanks for the merge. About d2bf649 (#68): I found it frustrating to try and implement the tests based on the dataset, as it is both incomplete and unnecessary complex - it just does not match the test cases. Why did you revert it? I feel like my proposed change makes it easier for contributors to get their tests working.

@hwillson
Copy link
Member

hwillson commented Mar 5, 2022

@spawnia thanks for the extra details. We might add this back in, but I wanted to talk it over with a few other people first, and didn't want to hold the rest of your PR up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@hwillson hwillson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spawnia @hwillson