Alphabetize fragment ordering in source text #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
approved these changes
Nov 8, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Nov 9, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 9, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Nov 9, 2023
8e730238 Alphabetize fragment ordering in source text (#130) git-subtree-dir: apollo-ios-codegen git-subtree-split: 8e7302381016d6b1422d3fd843766c84c5516cf1
BobaFetters
pushed a commit
that referenced
this pull request
Nov 9, 2023
…n source text git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 3f5048f git-subtree-split: 8e7302381016d6b1422d3fd843766c84c5516cf1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3296.
In some edge cases fragments were not ordered in the same way when creating the operation identifier and source text for the manifest vs. the
definitionin the generated operation model.This alphabetizes the fragments in both places to ensure a consistent ordering.