InstallCLI Plugin Updates #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Adding network request support to install cli plugin to download cli from github
Adding download cli script and calling it from the InstallCLI plugin
calvincestari
approved these changes
Nov 10, 2023
AnthonyMDev
approved these changes
Nov 10, 2023
AnthonyMDev
approved these changes
Nov 17, 2023
|
Going to hold off on merging this in until we are ready for the 1.8 release since its going to require using Xcode 15. |
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BobaFetters
added a commit
that referenced
this pull request
Jan 12, 2024
BobaFetters
added a commit
to apollographql/apollo-ios
that referenced
this pull request
Jan 12, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download-cli.shscript which handles most of the work for the plugin now@AnthonyMDev @calvincestari I have tested this in an SPM based project and an Xcode Project and everything appears to be working but would appreciate a little extra scrutiny just to make sure I didn't overlook a possible use case. There is a
cli-plugin-updatebranch onapollo-iosthat can be targeted for the SPM dependency to test this.