fix: @defer directive is duplicated when schema already has one
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
approved these changes
Jan 11, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jan 11, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jan 11, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jan 11, 2024
c7b03c2b fix: directive is duplicated when schema already has one (#235) git-subtree-dir: apollo-ios-codegen git-subtree-split: c7b03c2ba5bd70974189ee8d7e699cbe10eefdc7
BobaFetters
pushed a commit
that referenced
this pull request
Jan 11, 2024
…en schema already has one git-subtree-dir: apollo-ios-codegen git-subtree-mainline: ec6f3b0 git-subtree-split: c7b03c2ba5bd70974189ee8d7e699cbe10eefdc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick-fix for users on the router with a schema that supports defer.
The defer code merged into
mainmanually adds the@deferdirective to the schema because it is still an experimental spec directive. This is causing a duplicate directive error and is blocking codegen.All the Swift codegen tests for defer as being skipped now. This is OK-ish because defer is disabled in the JS frontend anyways so nobody can actually generate deferred operation models from
main. This will be reverted in thefeature/defer-execution-networkingbranch.