fix Custom Scalar should not be edited. output

[matsudamper]

fix: apollographql/apollo-ios#3323

cast to TemplateRenderer

apollo-ios-dev/apollo-ios-codegen/Sources/ApolloCodegenLib/FileGenerators/CustomScalarFileGenerator.swift

Lines 11 to 13 in cce0d07

	var template: TemplateRenderer {
	CustomScalarTemplate(graphqlScalar: graphqlScalar, config: config)
	}

Optional is different.

apollo-ios-dev/apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/CustomScalarTemplate.swift

Lines 23 to 25 in cce0d07

	func renderBodyTemplate(
	nonFatalErrorRecorder: ApolloCodegen.NonFatalError.Recorder
	) -> TemplateString {

The implementation of the extension is used.

apollo-ios-dev/apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/TemplateRenderer.swift

Lines 76 to 80 in cce0d07

	func renderHeaderTemplate(
	nonFatalErrorRecorder: ApolloCodegen.NonFatalError.Recorder
	) -> TemplateString? {
	TemplateString(HeaderCommentTemplate.template.description)
	}

relevance
#152

[apollo-cla]

@matsudamper: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[netlify]

👷 Deploy request for eclectic-pie-88a2ba pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	61a5f56

[AnthonyMDev]

Thanks so much for this bug fix! This test was missing and made this bug difficult to catch during my refactor.

[calvincestari]

Do we need to be worried that this was more than just a comment-related bug? I'd be far more concerned if we were actually overwriting pre-existing custom scalar files; do we need an additional test for that?

[AnthonyMDev]

No, this wouldn't have affected that. It was just a change in the function signature for the functions:

func renderHeaderTemplate(
     nonFatalErrorRecorder: ApolloCodegen.NonFatalError.Recorder
   ) -> TemplateString? {

func renderDetachedTemplate(
    nonFatalErrorRecorder: ApolloCodegen.NonFatalError.Recorder
  ) -> TemplateString? {
    nil
  }

and

func renderBodyTemplate(
    nonFatalErrorRecorder: ApolloCodegen.NonFatalError.Recorder
  ) -> TemplateString

It would not affect the logic for the overwriting.

[calvincestari]

Do we need to be worried that this was more than just a comment-related bug? I'd be far more concerned if we were actually overwriting pre-existing custom scalar files; do we need an additional test for that?

Executing the run-codegen.sh script on the 1.8.0 tagged release doesn't change any of the generated files and we have generated custom scalars in both AnimalKingdomAPI and GitHubAPI.

I've had a look through FileGeneratorTests and ApolloCodegenTests but I don't think we have a test that actually checks written file output to ensure nothing is written to pre-existing files that should not be overwritten.

[calvincestari]

No, this wouldn't have affected that. It was just a change in the function signature for the functions:

Sorry. I had my reply in draft for a while and didn't see your reply before posting it.