fix: Type case with only reserved fields is not composite inline fragment #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AnthonyMDev
approved these changes
Feb 9, 2024
Tests/ApolloCodegenTests/CodeGeneration/Templates/SelectionSet/SelectionSetTemplateTests.swift
Outdated
Show resolved
Hide resolved
...ests/Tests/3326-typeCaseWithOnlyReservedFieldSelectionIsNotCompositeInlineFragment/README.MD
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
calvincestari
deleted the
fix/type-case-generation-with-only-reserved-fields
branch
BobaFetters
pushed a commit
that referenced
this pull request
Feb 9, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Feb 9, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Feb 9, 2024
240aded0 fix: Type case with only reserved fields is not composite inline fragment (#261) git-subtree-dir: apollo-ios-codegen git-subtree-split: 240aded08862046db4c893ce0b4d04b86057c372
BobaFetters
pushed a commit
that referenced
this pull request
Feb 9, 2024
…ed fields is not composite inline fragment git-subtree-dir: apollo-ios-codegen git-subtree-mainline: f911089 git-subtree-split: 240aded08862046db4c893ce0b4d04b86057c372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3326.
TypeInfoofSelectionSetthat the root field builder uses to declaratively state whether a selection is composite or not.__selectionsarray into generated models. There is a default implementation of an empty__selectionsproperty in an extension that negates the need for us to do this in generated models.