Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility fixes for 1.9.1 #290

Merged
merged 5 commits into from Mar 8, 2024
Merged

Compatibility fixes for 1.9.1 #290

merged 5 commits into from Mar 8, 2024

Conversation

AnthonyMDev
Copy link
Contributor

1.9.1 Has a breaking change.

PR #286 which will go out in the next patch also had a breaking change.

This PR fixes both.

@AnthonyMDev AnthonyMDev requested a review from a team as a code owner March 8, 2024 21:37
@netlify Netlify
Copy link

netlify bot commented Mar 8, 2024 •
edited

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 381e70e
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/65eb8531b38cf20008d4a3b4

@netlify Netlify
Copy link

netlify bot commented Mar 8, 2024 •
edited

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 381e70e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/65eb85314cd60b00086f328b

calvincestari
calvincestari approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyMDev AnthonyMDev merged commit 671ce5f into main Mar 8, 2024
24 checks passed
@AnthonyMDev AnthonyMDev deleted the compatibility-fixes branch March 8, 2024 21:49
BobaFetters pushed a commit that referenced this pull request Mar 8, 2024
@AnthonyMDev
Compatibility fixes for 1.9.1 (#290)
2992f97
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Mar 8, 2024
@AnthonyMDev
Compatibility fixes for 1.9.1 (apollographql/apollo-ios-dev#290)
9e65157
BobaFetters pushed a commit that referenced this pull request Mar 8, 2024
Squashed 'apollo-ios/' changes from 569f814..9e65157
e5410b2 
9e65157 Compatibility fixes for 1.9.1 (#290)

git-subtree-dir: apollo-ios
git-subtree-split: 9e65157
BobaFetters pushed a commit that referenced this pull request Mar 8, 2024
split: apollo-ios - PR #290 - Compatibility fixes for 1.9.1
544c089 
git-subtree-dir: apollo-ios
git-subtree-mainline: 2992f97
git-subtree-split: 9e65157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AnthonyMDev @calvincestari @hishma