Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deprecated --schema-name property references #361

Merged
merged 2 commits into from
May 16, 2024

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented May 16, 2024

Closes apollographql/apollo-ios#3382.

There isn't much detail in that issue on what the actual problem is so I did an audit on where we might still be using --schema-name and found two outdated references; migration guide and CI action. This PR simply updates those to use the newer --schema-namespace.

Copy link
Contributor

It looks like you didn't add a description to your pull request. Please edit and add as much detail as possible for the reviewers. Pull requests require a description before they will be reviewed - thank you.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 5b23288
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/66465515727fe60008a705a4

Copy link

netlify bot commented May 16, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 5b23288
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/6646551593e51200089ecd41

@calvincestari calvincestari changed the title Chore/update deprecated schema name property chore: Update deprecated --schema-name property May 16, 2024
@calvincestari calvincestari changed the title chore: Update deprecated --schema-name property chore: Update deprecated --schema-name property references May 16, 2024
@calvincestari
Copy link
Member Author

Merging without approval since it's a known change to documentation and a CI command.

@calvincestari calvincestari merged commit dd54399 into main May 16, 2024
22 checks passed
@calvincestari calvincestari deleted the chore/update-deprecated-schema-name-property branch May 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant