Breakout Codegen IR to separate module #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved LinkedList and IsEverTrue into new “Utilities” target - Created OperationIdentifierFactory to move identifier computation back into ApolloCodegenLib
calvincestari
approved these changes
Sep 18, 2023
| .macOS(.v10_15), | ||
| .tvOS(.v12), | ||
| .watchOS(.v5) | ||
| .macOS(.v10_15) |
There was a problem hiding this comment.
Nice to be able to clean this up finally. That's a big win!
BobaFetters
pushed a commit
that referenced
this pull request
Sep 18, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Sep 18, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking the IR into it's own module allows us to remove the namespacing via an extension and improves organization and separation of concerns.
Operation identifier computation is now handled via a new
OperationIdentifierFactory.In my next PR, I'll be working on the ability to do custom operation identifier computation.