JSONConverter helper #380
Merged
JSONConverter helper #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
| /// Converts a ``SelectionSet`` into a basic JSON dictionary for use. | ||
| /// | ||
| /// - Returns: A `[String: Any]` JSON dictionary representing the ``SelectionSet``. | ||
| public static func convert(_ selectionSet: some SelectionSet) -> [String: Any] { |
There was a problem hiding this comment.
as you might have guessed from my PR, I'm not a fan of relying on the compiler to select the right overload, but that's my personal preference. The changes in this PR still work fine for my use case. Thanks for the help!
calvincestari
approved these changes
Jun 6, 2024
AnthonyMDev
force-pushed
the
data-dict-as-json-dictionary
branch
from
79a3e17
to
4a743b3
Compare
Yes, it's at GraphQLResultTests.swift:69 |
BobaFetters
pushed a commit
that referenced
this pull request
Jun 7, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jun 7, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jun 7, 2024
b52a8610 JSONConverter helper (#380) git-subtree-dir: apollo-ios git-subtree-split: b52a86100fd041481a9f191f4a1ab007069a41a1
BobaFetters
pushed a commit
that referenced
this pull request
Jun 7, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 4ef0f28 git-subtree-split: b52a86100fd041481a9f191f4a1ab007069a41a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative API for the changes in #377. It also cleans up the unit tests so we don't need to import
StarWarsAPIin more places (hoping we can get rid of it completely eventually).@TizianoCoroneo @calvincestari @BobaFetters I think this is an improvement on the API in the other PR. Let me know what you think.