Add referencedFragments to CompilationResult #39
Conversation
| expect(fragment?.referencedFragments).to(equal(expected)) | ||
| } | ||
|
|
||
| func test__referencedFragments__PetDetails_isCorrect() throws { |
There was a problem hiding this comment.
| func test__referencedFragments__PetDetails_isCorrect() throws { | |
| func test__referencedFragments__PetDetails_shouldNotHaveReferencedFragments() throws { |
Is something like that a clearer name for the test? isCorrect can mean many things.
There was a problem hiding this comment.
These are kind of odd tests because they test the example animal kingdom API. When that API, these tests need to be changed to accurately represent the correct information there. So changing the name also just doesn't add value. The only reason "shouldNotHaveReferencedFragments" is true is because the Pet Details fragment doesn't have any right now. It's not truly a test that "a fragment with no referenced fragments should have an empty referenced fragments array." The unit tests for this PR are the tests in the JS code. These are just some added integration tests.
| expect(operation?.referencedFragments).to(equal(expected)) | ||
| } | ||
|
|
||
| func test__referencedFragments__HeightInMeters_isCorrect() throws { |
There was a problem hiding this comment.
Is this test meant to be different from the test__referencedFragments__PetDetails_isCorrect test below?
| "WarmBloodedDetails", | ||
| "PetDetails" | ||
| ].map { expectedName in | ||
| compilationResult.fragments.first(where:{ $0.name == expectedName })! |
There was a problem hiding this comment.
This check looks like it's enforcing that the expected fragment name must be found but should the test also be validating that there are only the three referenced fragments?
apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/dist/ApolloCodegenFrontend.bundle.js
Outdated
Show resolved
Hide resolved
Allow us to track the referenced fragments from the js front end. This means we have access to this information prior to running the
IRBuilder.buildfunctions.We can now generate operation identifiers and manifests with this information without having to build the entire IR first.
This could also be used in the future to track dependencies between fragments to optimize the order of building (and releasing from memory) the fragments in the codegen.