-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code signing problems due to Apollo framework #14
Comments
Interesting, is there anything we can do to make this work out of the box? |
@stephensilber What was wrong with the codesigning? Can you provide the output of |
I haven't had a chance to look into this, but I'll be submitting another build either today or tomorrow and will make note of anything that may be useful, including the output of |
@stephensilber: Did you find out anything more about this? |
@martijnwalraven to work around it, I have been manually removing the custom build phase run script and the
Sorry for the late response. Let me know what else I can help do to debug this on my end |
Holy ****. I was also fighting with codesigning today for a TestFlight submission and got the same error, which didn't give me any clue what was going wrong. I will try to remove the run script, but that's probably not sufficient. I'm using Carthage, so I really don't know how to automate this 🤔 |
Can that .sh script be moved into the build phase run script* so it's not a piece of **fixed some typos from posting this on mobile On Mon, Nov 21, 2016 at 2:31 PM Alex Hüllmandel notifications@github.com
|
I'm still unsure how to tackle this and I have no reference project to look into. |
I think the correct way to not have
to
Thus preserving the @stephensilber can you try that and see if it helps? Update: The above comment is still valid, though, because I don't think we want to ship this script in the released app IPA. |
If the script wasn't in the targets I could also reference it through the |
I came across this, so it seems it is a known issue and affects other frameworks as well. Not sure yet what the root cause is and whether there are any workarounds that don't involve removing the script from the bundle. |
Yeah, I read the same thing :) |
Not sure about Carthage, but for Cocoapods the solution is what @maxsz suggested. |
Yeah, this definitely works for Cocoapods |
We've figured it out! |
This fixes "Code signing problems due to Apollo framework apollographql#14" by not adding the `check-and-run-apollo-codegen.sh` script to the framework resources.
I've created a pull request which should fix this for Cocoapods and Carthage. |
This fixes "Code signing problems due to Apollo framework apollographql#14" by not adding the `check-and-run-apollo-codegen.sh` script to the framework resources.
I just finished debugging a bunch of problems I was having submitting a build to TestFlight, and the root of the cause seems to have been the
check-and-run-apollo-codegen.sh
file in the Apollo framework (installed via Cocoapods). I removed that file from the project and temporarily removed the run script from my own project build phases, and the code signing finally succeeded. Here is the error I got:Hopefully this will help any one else having this problem
The text was updated successfully, but these errors were encountered: