Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions #60

Closed
Chrisdf opened this issue Feb 13, 2017 · 32 comments
Closed

Subscriptions #60

Chrisdf opened this issue Feb 13, 2017 · 32 comments

Comments

@Chrisdf
Copy link

Chrisdf commented Feb 13, 2017

Hi, I am trying to develop against a GraphQL server which heavily relies on subscriptions. I would love to not have to use the Javascript Apollo Client in React Native, but cannot seem to figure out if there is an already included way to implement subscriptions with this library. If there is not, is there possibly another Swift/Objective-C library which has this capability?

@martijnwalraven
Copy link
Contributor

Subscriptions are not yet supported, but they are definitely on the road map, and we should be able to implement them in the next couple of months. I don't know of any other native libraries supporting GraphQL subscriptions.

@stubailo
Copy link
Contributor

If someone has ideas or wants to send a PR this is a great place to discuss!

@bchrobot
Copy link

How do the authors feel about using a 3rd party library like Starscream for handling web sockets?

@martijnwalraven
Copy link
Contributor

@bchrobot: I think that's a given, we definitely don't want to develop our own websocket library :) Starscream seems like a great option. Do you have any experience with it?

@MrAlek
Copy link
Contributor

MrAlek commented Feb 20, 2017

@martijnwalraven @bchrobot I've used Starscream for a hobby project in the past, super smooth to get going with. Definitely worth exploring.

@bchrobot
Copy link

@MrAlek That has been my experience with it as well.

@martijnwalraven Has planning for this feature been started? My group is very excited about this feature and could start on a PR for it

@martijnwalraven
Copy link
Contributor

@bchrobot: We haven't really started planning, I just have some ideas. So it would be great if you wanted to get started on it!

@attheodo
Copy link

Any updates on subscriptions? Is there a roadmap?

@martijnwalraven
Copy link
Contributor

We have some work on caching and the imperative read/write API to finish and merge first, but I suspect subscriptions will be one of the next things to work on after that! (These things are also something of a prerequisite for it.)

@mwurm93
Copy link

mwurm93 commented Jun 8, 2017

@martijnwalraven any idea of the timeline for subscriptions support?

@florianmari
Copy link

Hey guys, I'm working on GraphQL Subscription Library (LiveGQL) when I finish it and have a good library I'm gonna check to make a Pull Request on Apollo-iOS (in next few months I guess)

@stami
Copy link

stami commented Sep 29, 2017

@florianmari Any updates on integrating it to Apollo? :)

@Gregoirevda
Copy link
Contributor

Any upgrades???

@LeeWong
Copy link

LeeWong commented Nov 14, 2017

Any updates? Thanks.

@martijnwalraven
Copy link
Contributor

It would be great if people are interested in contributing! Please join the #ios-core channel on the Apollo Slack if you want to discuss further. We're working on some changes to the networking layer that should make it easier to integrate with other transports.

@psi-gh
Copy link
Contributor

psi-gh commented Feb 1, 2018

Update? :)

@matthewcheok
Copy link

Interested to help push this forward, any ideas on what it would take to implement this?

@florianmari
Copy link

Interested to work with someone to implement it to Apollo, I think now it's one of the biggest missed feature in this library! I updated mine with SocketRocket and it would be better if my library (or any new ones) would be integrated within Apollo instead of having a separated one

@martijnwalraven
Copy link
Contributor

@matthewcheok @florianmari Work on the new networking layer seems to have stalled, but would be great to start this up again. Once we have a more flexible pluggable transport, adding support for subscriptions should be relatively straightforward.

Let's coordinate on the #ios-core channel on the Apollo Slack. It's been a while since we've had a contributor meeting, but that may help get more people involved again.

@jgavris
Copy link

jgavris commented Feb 5, 2018

@martijnwalraven is the channel #ios-contributors? I would like to participate on the subscriptions effort as we need it very soon.

@martijnwalraven
Copy link
Contributor

@jgavris Oh yes, sorry, we renamed it to #ios-contributors.

@tomasrequenab
Copy link

A question .. Are subscriptions not supported in Apollo iOS Client yet?

@florianmari
Copy link

@tomasrequenab No yet

@tomasrequenab
Copy link

@florianmari What about LiveGQL library?

@taion
Copy link

taion commented Mar 16, 2018

Not in a first-class manner on the network side, but all the functionality to upload the store based on out-of-band subscription responses is present.

See e.g. the AWS AppSync iOS code: https://github.com/awslabs/aws-mobile-appsync-sdk-ios/blob/3fbd248440115d1b913fabc9290eb9d7d4bc9a9b/AWSAppSyncClient/AWSAppSyncSubscriptionWatcher.swift#L111-L135

@jgavris
Copy link

jgavris commented Mar 16, 2018

Please check out #220 !

@oliviertouron-playster
Copy link

oliviertouron-playster commented Apr 20, 2018

Hello guys,
Do you have an idea when Subscription on iOS will be available (official version)?
Thx

@gpambrozio
Copy link
Contributor

Seems to have been added in #220

@DarkDust
Copy link

DarkDust commented Nov 6, 2018

Since #220 has been merged and released, can we close this one?

@ex3ndr
Copy link

ex3ndr commented Mar 27, 2019

While subscriptions are received events are not merged to a storage, is it designed as intended?

@jdrydn
Copy link

jdrydn commented Apr 4, 2019

Also worth noting there's no documentation at all for subscriptions, doesn't appear to be a part of #220 🤷‍♂️

@designatednerd
Copy link
Contributor

Hey all, I'm going to close this as we do have the subscriptions method through the Apollo-Websocket subspec.

If there's separate issues with the Apollo-Websocket implementation I'd ask you to please re-file them so that when I get a chance to give that implementation some love I know what's still a problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests