Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Websockets #1004

Merged
merged 12 commits into from
Feb 13, 2020
Merged

Conversation

fassko
Copy link
Contributor

@fassko fassko commented Feb 6, 2020

  • allow to opt-out for reconnection
  • allow to disable duplicate messages when reconnecting

Need to import UIKit/AppKit if using -passthroughCustomScalars when building and SwiftPM
* allow to specify if sending duplicate messages when reconnecing
* opt out for auto-reconnection
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions!

Sources/ApolloWebSocket/WebSocketTransport.swift Outdated Show resolved Hide resolved
Sources/ApolloWebSocket/WebSocketTransport.swift Outdated Show resolved Hide resolved
@designatednerd designatednerd merged commit 1f49541 into apollographql:master Feb 13, 2020
@designatednerd designatednerd added this to the 0.22.0 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants