Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove @inlinable from ApolloAPI to enable xcframework builds #2613

Merged
merged 2 commits into from Oct 27, 2022

Conversation

calvincestari
Copy link
Member

Closes #2555

This PR enables BUILD_LIBRARY_FOR_DISTRIBUTION to be used when building an xcarchive which in turn enables building of an xcframework.

  • Removes @inlinable where needed from ApolloAPI function declarations.
  • This does not change our stance on Library Evolution, it is still not officially supported. If there is a way in the future to disassociate swiftinterface generation from the BUILD_LIBRARY_FOR_DISTRIBUTION build setting we will likely make that choice.
  • This does not change our stance on Carthage, we are still moving away from officially supporting it.

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit e277daf
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/635a0e7f072b260008ab27fc

@calvincestari calvincestari merged commit 4f220aa into main Oct 27, 2022
@calvincestari calvincestari deleted the fix/manual-xcframework-builds branch October 27, 2022 04:54
@calvincestari calvincestari mentioned this pull request Nov 1, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 1.0 installation (Carthage or xcodebuild archive) failures
1 participant