Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed reading of the itemsToGenerate property for the operation manifest #3215

Conversation

TizianoCoroneo
Copy link
Contributor

The current implementation of the codegen checks for itemsToGenerate to be exactly equal to .operationManifest in order to trigger its relative operation.
I think this is a mistake, as it makes it so that the .all option actually only generates the .code part.

@netlify
Copy link

netlify bot commented Sep 8, 2023

👷 Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c506b9d

@TizianoCoroneo TizianoCoroneo changed the title fix: Fixed reading of the itemsToGenerate property for the operation manifest fix: Fixed reading of the itemsToGenerate property for the operation manifest Sep 8, 2023
Copy link
Member

@BobaFetters BobaFetters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and contributing the fix!

@BobaFetters BobaFetters merged commit e76c9e7 into apollographql:main Sep 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants