Detection of 'GlobalApolloCodegen' happens too early in Gradle configuration #1203
Comments
tasomaniac
added a commit
to tasomaniac/apollo-android
that referenced
this issue
Jul 22, 2019
…egen installation Move Apollo global verification to the beginning of the task to speed up configuration process. Before, this I/O operation (version check) would run in configuration time and take up to 5sec. This runs in every Gradle execution (even when unrelated to Apollo) This commit fixes apollographql#1203 and moves verification to a later stage. This means that we cannot easily fall-back to local installation that easily. That's why an exception is thrown with an appropriate message. User should disable using this feature if they don't have global installation.
This was referenced Jul 22, 2019
sav007
pushed a commit
that referenced
this issue
Jul 24, 2019
* Fix: Speed up build configuration time by lazily verifying apollo-codegen installation Move Apollo global verification to the beginning of the task to speed up configuration process. Before, this I/O operation (version check) would run in configuration time and take up to 5sec. This runs in every Gradle execution (even when unrelated to Apollo) This commit fixes #1203 and moves verification to a later stage. This means that we cannot easily fall-back to local installation that easily. That's why an exception is thrown with an appropriate message. User should disable using this feature if they don't have global installation. * Replace println with info logs * Move verification into exec. doFirst does not really run first
tasomaniac
added a commit
to tasomaniac/apollo-android
that referenced
this issue
Jul 26, 2019
…egen installation Move Apollo global verification to the beginning of the task to speed up configuration process. Before, this I/O operation (version check) would run in configuration time and take up to 5sec. This runs in every Gradle execution (even when unrelated to Apollo) This commit fixes apollographql#1203 and moves verification to a later stage. This means that we cannot easily fall-back to local installation that easily. That's why an exception is thrown with an appropriate message. User should disable using this feature if they don't have global installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the following option is used
systemProp.apollographql.useGlobalApolloCodegen=true, Apollo plugin spends some time to validate the installation of the global apollo codegen.This validation happens on configuration time. Even-though everything is cached in a module, this happens every-time, anybody runs any Gradle task in the project.
This takes maybe around couple seconds but it also depends on the computer. Would be good to do this lazily.
The text was updated successfully, but these errors were encountered: