Use standard logging API for quieter codegen verification #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Printing this to stdout means it gets printed every time and is quite noisy. This changes it to log the start and happy path to info, and warn on errors
|
I think this PR #1451 will address this issue. |
|
Yep. I am going to update it real quick. Also these messages are not going to be this frequent anyways. They will only be logged when actual codegen runs. |
|
I believe we can close this as it was addressed as part of #1451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing this to stdout means it gets printed every time and is quite noisy. This changes it to log the start and happy path to info, and warn on errors