Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] check versions lazily #2400

Merged

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Jun 26, 2020

closes #2393

This pull request is dependent on #2399, I'll rebase once it is merged.
This PR moves checking the versions to task configuration (instead of plugin application before). This gives more time to other plugins like the Kotlin plugin to change dependencies if needed.

@martinbonnin martinbonnin force-pushed the bug-2393/check-versions-lazily branch from 00a3adf to 2f7e4ee Compare June 29, 2020 11:42
Copy link
Contributor

@tasomaniac tasomaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@martinbonnin martinbonnin merged commit 4657be0 into apollographql:master Jun 30, 2020
@martinbonnin martinbonnin deleted the bug-2393/check-versions-lazily branch June 30, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin error: "Cannot change dependencies of dependency configuration"
2 participants