[Plugin] allow running the plugin on Gradle 5.6 #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
changed the title
given that the poms reference the jvm projects
martinbonnin
force-pushed
the
bug-2536/gradle-5-compat
branch
from
a970d51
to
f09381d
Compare
tasomaniac
reviewed
Aug 26, 2020
| @@ -39,4 +39,5 @@ interface ApolloExtension: CompilerParams { | |||
| */ | |||
| fun onCompilationUnit(action: Action<CompilationUnit>) | |||
|
|
|||
| val relaxGradleVersionCheck: Property<Boolean> | |||
There was a problem hiding this comment.
Why not just remove the restriction without the flag? 😉
There was a problem hiding this comment.
Yea, that's the other option. There might be some edge cases that are not working with 5.6 though
tasomaniac
approved these changes
Aug 28, 2020
martinbonnin
changed the title
|
Thanks for making it! It'll be clearer that way and we can always refine later if/when we find edge cases with 5.6 |
martinbonnin
added a commit
that referenced
this pull request
Sep 16, 2020
* [SQLNormalizedCache] fix watcher not called on initial cache write (#2538) * when no record was present in the cache, return all changed keys * add a unit test * add an integration test * wait for the second resposne * remove debug * Update dependency gatsby-theme-apollo-docs to v4.3.10 * [Compiler] fix optional Int properties with an uppercase name (#2543) * use the field name for class properties, not the schema name fixes #2541 * add built in introspection types to SDL parser Also: - remove leading whitespace in block strings - remove leading trailing quotes when parsing String default values * normalize Json numbers, GraphQL Ints and Floats to Kotlin Double * use SDL schemas for codegen tests * update test fixtures * move the SDL definitions to a separate file * Bump kotlin compile testing (#2547) * bump kotlin compile testing * enable warnings again * [Plugin] allow running the plugin on Gradle 5.6 (#2539) * add skipGradleVersionCheck * rename to relaxGradleVersionCheck * remove doc * remove the Gradle 6 mention. It turns out Gradle 5.6 should work fine given that the poms reference the jvm projects * update metalava * allow 5.6 more globally * Minor doc edits (#2548) * fix a bad copy/paste in the doc and take this opportunity to add more doc about the structure of generated models * add the apollo icon to the .idea folder * add spaces before and after the MultiCodeBlocks * Update dependency gatsby-theme-apollo-docs to v4.4.1 * Update dependency gatsby-theme-apollo-docs to v4.4.2 * Update dependency gatsby to v2.24.52 * Put the location of the .xcodeproj file for Kotlin Multiplatform Mobile integration in Android Studio (#2554) * compile Kotlin against stdlib 1.3 (#2555) See https://issuetracker.google.com/issues/166582569 * Update dependency gatsby-theme-apollo-docs to v4.4.3 * Update dependency gatsby to v2.24.53 * Update mutations.mdx (#2561) * bump sql delight version (#2564) * Multi-module support (#2514) * First drop for multi-module support * update metalava * add alwaysGenerateTypesMatching and a few unit tests * added some tests * minor tweaks * update metalava * stay on Gradle 6.0 * add more gradle tests * wip * wip * better place to put the workaround * add experimental markers * remove some references to zip * fix test * add a test for diamond-shaped dependencies * work in progress on a duplicates task * add more tests * fix tests * remove debug * typo * in the compiler module, use 'metadata' instead of 'multi-module' * added a few comments * fix tests * make Service and Variant public * update metalava * [Sdl] Fix a scalar definition after a union defintion (#2559) * modify the test case to make it fail * give more context if an error heppens during `toIntrospectionSchema` * fix the union possible types were eating the following scalar definitions * bump Kotlin version (#2568) * Update dependency gatsby to v2.24.57 * Remove toDeferred in favor of await. (#2574) Closes #2571 * Bump Kotlin to 1.4.10 (#2578) * Add a link to the Kotlin slack (#2576) * add Kotlin as language for the codeblock (#2580) * make compile * make it compile * fixes * make CodegenTests pass * fix some tests * fix some more tests Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Said Tahsin Dane <taso.dane@deliveryhero.com> Co-authored-by: Jagdeep Nagpal <jagdeepnagpal@gmail.com> Co-authored-by: Ahmed I. Khalil <ahmedibrahimkhali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ApolloExtension.relaxGradleVersionCheckas a workaround for users stuck on Gradle 5.6. Anything lower than Gradle 5.6 will not work because the plugin is using some 5.6 Provider APIs likeProvider.orElseFixes #2536