[Gradle Plugin] Make CheckDuplicate task cacheable #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveeyay
requested review from
martinbonnin,
sav007 and
tasomaniac
as code owners
tasomaniac
approved these changes
Oct 22, 2020
martinbonnin
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Make ApolloCheckDuplicatesTask cacheable * Combining both gradle cache unit tests * Fixing unit test * Trying another way to test the caching Co-authored-by: Olivier Goutay <ogoutay@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2681
Summary
When enabling the gradle build cache, since ApolloCheckDuplicatesTask is not marked as a CacheableTask (but has an output), this task won't be optimized against the same generated models (ApolloGenerateSourcesTask is already marked as a CacheableTask).