[Compiler] support multiple arguments in directives #2711

martinbonnin · 2020-10-29T10:39:06Z

martinbonnin · 2020-10-29T10:40:02Z

apollo-compiler/src/main/antlr/com/apollographql/apollo/compiler/parser/antlr/GraphQL.g4

@@ -96,7 +96,7 @@ directives
   ;

 directive
-   : '@' NAME ':' valueOrVariable | '@' NAME | '@' NAME '(' argument ')'
+   : '@' NAME arguments?


Not sure what the ':' was up there but I didn't find it in http://spec.graphql.org/draft/#Directives so I'm assuming it's safe to remove that case.

...er/src/main/kotlin/com/apollographql/apollo/compiler/parser/graphql/GraphQLDocumentParser.kt

martinbonnin added 2 commits October 29, 2020 11:37

support multiple arguments in directives

46a1fc1

update test fixtures

6f18b25

martinbonnin requested review from sav007 and tasomaniac as code owners October 29, 2020 10:39

martinbonnin commented Oct 29, 2020

View reviewed changes

...er/src/main/kotlin/com/apollographql/apollo/compiler/parser/graphql/GraphQLDocumentParser.kt Show resolved Hide resolved

sav007 approved these changes Oct 30, 2020

View reviewed changes

martinbonnin merged commit b356f5a into main Oct 30, 2020

martinbonnin deleted the bug-2708/multiple-directive-arguments branch October 30, 2020 09:37

Provide feedback