Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unconditionnaly add the message to the Kotlin Decprecated annotation #2720

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Nov 2, 2020

#2692 fixed the @deprecated without arguments, this pull request fixes @deprecated(reason: "").

Note: It feels a bit weird to have a @deprecated annotation without a reason but I don't think it's correct to default to "No longer supported" for blank reasons as the schema explicitly defines the empty string as the reason.

Closes #2714

@martinbonnin martinbonnin merged commit c330ab4 into main Nov 2, 2020
@martinbonnin martinbonnin deleted the bug-2714/deprecated-with-blank-message branch November 2, 2020 10:48
@martinbonnin
Copy link
Contributor Author

Merging this quickly to include in today's version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin models for kotlin 1.4.x generated with Deprecated tags throw errors when building.
1 participant