Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3095: Expose channel capacity parameter. #3096

Merged
merged 1 commit into from
May 6, 2021
Merged

Issue #3095: Expose channel capacity parameter. #3096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions .../commonMain/kotlin/com/apollographql/apollo/network/ws/ApolloWebSocketNetworkTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ class ApolloWebSocketNetworkTransport(
private val connectionParams: Map<String, Any?> = emptyMap(),
private val connectionAcknowledgeTimeoutMs: Long = 10_000,
private val idleTimeoutMs: Long = 60_000,
private val connectionKeepAliveTimeoutMs: Long = -1
private val connectionKeepAliveTimeoutMs: Long = -1,
private val channelCapacity: Int = Channel.CONFLATED
) : NetworkTransport {
private val mutex = Mutex()
private var graphQLWebsocketConnection: GraphQLWebsocketConnection? = null
Expand Down Expand Up @@ -155,6 +156,7 @@ class ApolloWebSocketNetworkTransport(
webSocketConnection = webSocketConnection,
idleTimeoutMs = idleTimeoutMs,
connectionKeepAliveTimeoutMs = connectionKeepAliveTimeoutMs,
channelCapacity = channelCapacity,
defaultDispatcher = dispatcherContext.default
)
}
Expand All @@ -175,9 +177,10 @@ class ApolloWebSocketNetworkTransport(
val webSocketConnection: WebSocketConnection,
val idleTimeoutMs: Long,
val connectionKeepAliveTimeoutMs: Long,
channelCapacity: Int = Channel.CONFLATED,
defaultDispatcher: CoroutineDispatcher
) {
private val messageChannel: BroadcastChannel<ByteString> = webSocketConnection.broadcast(Channel.CONFLATED)
private val messageChannel: BroadcastChannel<ByteString> = webSocketConnection.broadcast(channelCapacity)
private val coroutineScope = CoroutineScope(SupervisorJob() + defaultDispatcher)
private val mutex = Mutex()
private var activeSubscriptionCount = 0
Expand Down