Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Codegen #3335

Merged
merged 3 commits into from Sep 7, 2021
Merged

Java Codegen #3335

merged 3 commits into from Sep 7, 2021

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Sep 2, 2021 •
edited

See #2616

This PR is huge because it contains all the test fixtures. Look at the first commit for a more reasonnable diff.

@martinbonnin
Copy link
Contributor Author

The JavaCodegen can now be verified with integration-tests and operation-based-tests. This is nice because the same Kotlin code is used to test both codegens. The only thing that needed to change is the removal of named parameters that are not working when calling Java code.

The Java codegen could be further improved with:

  1. @NonNull/@Nullable annotations, ideally user-configurable
  2. Builder APIs, especially for input objects to allow omitting input fields
  3. Use of primitive types for non-nullable fields for performance reasons

@martinbonnin martinbonnin merged commit 09e6544 into dev-3.x Sep 7, 2021
@martinbonnin martinbonnin deleted the java-codegen branch September 7, 2021 08:24
@martinbonnin martinbonnin mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sav007 sav007 Awaiting requested review from sav007

@tasomaniac tasomaniac Awaiting requested review from tasomaniac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinbonnin