add DslMarker for test builders #4089
Conversation
|
@hrach: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
|
I love this! Looks really cool 👍! To be on the exhaustive side might want to add a test but TBH this is going to be hard to test because we need to test that something does not compile. It's doable but I don't think it's worth the trouble. @BoD any thoughts. |
|
Agreed 😊 I was not familiar with the annotation so an example of what was possible before / not possible after would be cool but we can just try on the branch, I agree a test is not necessary. |
|
@hrach can you run |
Before
After
👍 |
|
Hi guys, thanks for guidance for the API dump. I'll do this. Testing: I was thinking about doing something, but "not compiling" requirement seemed rather very difficult to do for some trivial code. Thank you for trying out. :) |
Introduce a custom DslMarker for MapBuilder. This way nesting builders won't see their parent implicit receiver and users cannot define parent receiver's properties without an explicit receiver reference.
|
rebased |
Introduce a custom DslMarker for MapBuilder. This way nesting builders
won't see their parent implicit receiver and users cannot define
parent receiver's properties without an explicit receiver reference.