Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the 'interfaces' field on the JSON introspection #4129

Merged
merged 2 commits into from
May 24, 2022

Conversation

BoD
Copy link
Contributor

@BoD BoD commented May 20, 2022

Related to #4126.

I'm wondering if we should save the introspection JSON as-is instead of parsing it and then serializing it, in SchemaDownloader? 🤔

@netlify
Copy link

netlify bot commented May 20, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 765d7d9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/628b4d912e30ed0009b2b62c

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should save the introspection JSON as-is instead of parsing it and then serializing it, in SchemaDownloader?

That'd avoid this kind of things moving forwad. I'm all for it 👍

@BoD BoD merged commit f0c7e36 into main May 24, 2022
@BoD BoD deleted the introspection-interfaces branch May 24, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants