Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use okio.Closable.close instead of dispose on ApolloClient #4142

Merged
merged 1 commit into from
May 30, 2022
Merged

Use okio.Closable.close instead of dispose on ApolloClient #4142

merged 1 commit into from
May 30, 2022

Conversation

yogurtearl
Copy link
Contributor

related to #4084

@netlify
Copy link

netlify bot commented May 26, 2022

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 11c94b2

@yogurtearl yogurtearl mentioned this pull request May 26, 2022
Closed
BoD
BoD approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🙏

@martinbonnin
Copy link
Contributor

Thanks a lot for the contribution !
That'll be super useful in integration tests where forgeting to close an ApolloClient just hangs forever!

@martinbonnin martinbonnin merged commit 63ad6fc into apollographql:main May 30, 2022
@yogurtearl yogurtearl mentioned this pull request May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@martinbonnin martinbonnin martinbonnin approved these changes

@sav007 sav007 Awaiting requested review from sav007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yogurtearl @martinbonnin @BoD