Allow capitalized field names if flattenModels is true

[BoD]

• If flattenModels is true, then it's OK to have field names with the same name as the corresponding model - disable the validation in that case.
• Fix a few other cases where there were still name conflicts (Adapter and Selections)

Related to #4152

[netlify]

✅ Deploy Preview for apollo-android-docs canceled.

Name	Link
🔨 Latest commit	10d1211
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-android-docs/deploys/6298c0620a9a2400092098ff

[martinbonnin]

Looks like the only case where this is public is the root field? In that case, you could rename the root field to __root (technically source breaking but I think that's ok?) and escape indiscriminately, just like for variables?

All in all, I think I'd do this:

• __typename -> never escape
• __root -> never escape
• variables -> always escape
• add a new compiledSelectionsName() that would always escape.

[martinbonnin]

Digging into this again. Do you remember why we needed to escape the compiled selections? They look like this:

public object TestQuerySelections {
  private val __onDroid: List<CompiledSelection> = listOf(..)
  private val __hero: List<CompiledSelection> = listOf(..)
  // ...
  public val __root: List<CompiledSelection> = listOf(..)
}

This is all private (except __root) and this file has some code to resolve name clashes:

apollo-kotlin/apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/kotlin/selections/CompiledSelectionsBuilder.kt

Line 51 in 89a439c

private fun resolveNameClashes(usedNames: MutableSet<String>, modelName: String): String {

. So escaping doesn't sound needed? Do you remember the details?

[BoD]

You're right, it looks like escaping is unnecessary - not sure why we did this 😅 Maybe we overlooked the fact that only __root is public?

[martinbonnin]

🚀