Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect content-length in MockServer #4162

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jun 2, 2022

When a string contains non 8 bit characters, its Java length is not equal to its utf-8 encoded length. This caused receiving truncated responses from MockServer.

Thanks @StylianosGakis for finding this! 🙏

@netlify
Copy link

netlify bot commented Jun 2, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 0b2f52d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6298f62c2efad90009131b0d

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BoD BoD merged commit 044a752 into main Jun 2, 2022
@BoD BoD deleted the fix-mockserver-wrong-content-length branch June 2, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants