Add more cache benchmarks and run them in CI #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
approved these changes
Jun 29, 2022
|
On hold for gradle/gradle#21125 |
Never mind, we can use AGP alpha04 for now so we can stick with Gradle 7.4.2. Marking as ready for review again |
BoD
approved these changes
Jun 30, 2022
Co-authored-by: Benoit Lubek <BoD@JRAF.org>
martinbonnin
force-pushed
the
add-benchmarks
branch
from
ee6f4b0
to
b6dd286
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Cache benchmarks based on @sebj data.
Thanks a lot to him for providing real life data to monitor the cache performance 💙
It also adds a new CI target that runs the benchmarks in Firebase Test Lab.